Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible double-free #109

Open
Ten0 opened this issue Oct 28, 2024 · 0 comments
Open

Possible double-free #109

Ten0 opened this issue Oct 28, 2024 · 0 comments

Comments

@Ten0
Copy link
Contributor

Ten0 commented Oct 28, 2024

This commit:

YifangSun@d96bdd1#diff-79f9ddb64f1be76f0a0837f3c47b12dddaf2b4aeed5e5e12cf93d42aabaf87abR473

Seems to be fixing double-free errors.
One should probably check whether they can actually happen, and if so, fix them in this main repo.
I'm not sure this is the appropriate way to fix them though. (The proposed "fix" seems to leave a potentially invalid object with a null ptr inside. Instead, functions that disconnect should probably take ownership, to avoid re-use of a disconnected client.)

@YifangSun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant