Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exporting Directory.list in cephfs package #234

Closed
phlogistonjohn opened this issue Apr 29, 2020 · 2 comments
Closed

Consider exporting Directory.list in cephfs package #234

phlogistonjohn opened this issue Apr 29, 2020 · 2 comments

Comments

@phlogistonjohn
Copy link
Collaborator

In a comment on #217 we have interest in having the list function exported. This is a convenience function that returns all entries in a directory in a single slice.

Alternatively, I had considered a ListN(int) version that could possibly split the difference between convenience and scalability.

@phlogistonjohn
Copy link
Collaborator Author

This was discussed recently over voice chat and we came to the conclusion that a very-thin list function is probably too "middle ground" outside of a few narrow use cases.

Rather, if we build on top of ceph_readdirplus_r we can get results that are similar (if not the same as) the Go os packages FileInfo result type. Using that we can more closely match the os-agnostic results that many Go programs expect to achieve.

@phlogistonjohn
Copy link
Collaborator Author

Closing this as a duplicate of #326 as that issue was filed by a non-maintainer and demonstrates some demand rather than my pure speculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant