Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember the user's choice of dark or light mode #57

Open
ljflores opened this issue Aug 22, 2023 · 2 comments
Open

Remember the user's choice of dark or light mode #57

ljflores opened this issue Aug 22, 2023 · 2 comments
Labels
enhancement Making existing feature better

Comments

@ljflores
Copy link
Member

The current logic seems to be (correct me if I'm wrong) dark mode by default. To streamline this option, and if it's not too much overhead, it might be good to have the interface remember which setting the user chose last time they logged in.

I seem to remember the concept of user profiles being introduced in the pulpito-ng demo? This could perhaps be a setting associated with a user's profile.

@kamoltat
Copy link
Member

Yep I thanks for pointing this out, we can add this when we integrate the auth feature into production, just only need to figure out how exactly it should look like when we save the user's choice, probably somewhere in the metadata recording user login/logout timestamp

@kamoltat kamoltat added the enhancement Making existing feature better label Oct 25, 2023
@dikwickley
Copy link

@kamoltat how about saving the the choice in browser's local storage or even cookies.
We can even keep another option to keep it as the system's default.

If this sounds good I would like to work on it (or any other way you might suggest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making existing feature better
Projects
None yet
Development

No branches or pull requests

3 participants