Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you open to some new classes? #8

Open
himedlooff opened this issue Nov 21, 2013 · 2 comments
Open

Are you open to some new classes? #8

himedlooff opened this issue Nov 21, 2013 · 2 comments

Comments

@himedlooff
Copy link
Contributor

There are a few instances of directly styling all elements when you should probably use a class for example:

section:before {
    display: block; 
    content: ""; 
    height: 60px; 
    margin: -60px 0 0; 
}

...

header {
    width: 100%;
    border-top: 4px solid #2CB34A;
    border-bottom: 1px solid #BABBBD;
    background-color: #fff;
    position: fixed;
    top: 0;
    z-index: 99999;
    height: 3.625em;
}

Are you open to swapping some of these for class names?

@ascott1
Copy link
Member

ascott1 commented Nov 21, 2013

Totally open to it. All of the CSS was written in crunch mode when launching eRegs so I'm sure it needs a little love.

@himedlooff
Copy link
Contributor Author

Ok cool, good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ascott1 @himedlooff and others