From edc2705e8d2d8e9ce42797c91dfc4694601c14dc Mon Sep 17 00:00:00 2001 From: Bill Himmelsbach Date: Wed, 31 Jan 2024 07:17:11 -0800 Subject: [PATCH] fix(Navbar): CFPB logo always takes you to consumerfinance.gov (#296) The CFPB logo should always navigate to consumerfinance.gov instead of a generic / to allow for applications with their own routing that are using the navbar, as per @natalia-fitzgerald's designs. ## Changes - change `href` to be `https://www.consumerfinance.gov/` ## How to test this PR 1. Does clicking the CFPB logo in the NavBar take you to the CFPB home page? ## Notes - we could make the logo's `href` into a prop, but clicking this logo across all CFPB properties should take you to `www.consumerfinance.gov`, so it's better to hardcode it for consistency --- src/components/Navbar/Navbar.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/components/Navbar/Navbar.tsx b/src/components/Navbar/Navbar.tsx index 6257e660..af341038 100644 --- a/src/components/Navbar/Navbar.tsx +++ b/src/components/Navbar/Navbar.tsx @@ -5,7 +5,12 @@ import './navbar.less'; export function CfpbLogo(): JSX.Element { return ( - + CFPB Logo );