Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Expandable] Correct icon color #391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [Expandable] Correct icon color #391

wants to merge 1 commit into from

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Jan 10, 2025 •
edited
Loading

Closes #385

Changes

  • Match structure of DS Expandable component to allow the existing CSS styles for icon color to be correctly applied to the DSR Expandable

How to test this PR

  1. Compare screenshots
  2. Compare live examples

Screenshots

Before

Screenshot 2025-01-10 at 11 23 29 AM

After

Screenshot 2025-01-10 at 11 22 56 AM

DS Expandable

Screenshot 2025-01-10 at 12 37 01 PM Screenshot 2025-01-10 at 12 37 17 PM

@netlify Netlify
Copy link

netlify bot commented Jan 10, 2025 •
edited
Loading

✅ Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 4b24c6f
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/678177568e635f0008ea3702
😎 Deploy Preview https://deploy-preview-391--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia requested a review from virginiacc January 10, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

@ojbravo ojbravo Awaiting requested review from ojbravo ojbravo is a code owner

@tanner-ricks tanner-ricks Awaiting requested review from tanner-ricks

@virginiacc virginiacc Awaiting requested review from virginiacc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Expandable] Sync to Design System
1 participant
@meissadia