Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design Review] [FooterCfGov] Too much white space below footer when zoomed out #365

Closed
shindigira opened this issue Apr 2, 2024 · 0 comments · Fixed by #369
Closed

[Design Review] [FooterCfGov] Too much white space below footer when zoomed out #365

shindigira opened this issue Apr 2, 2024 · 0 comments · Fixed by #369
Assignees
@shindigira
Labels
bug Something isn't working enhancement New feature or request

Comments

@shindigira
Copy link
Contributor

shindigira commented Apr 2, 2024 •
edited
Loading

Problem

Too much white space below footer when zoomed out (press CMD + - a few times)

Screenshots of the problem

Screenshot 2024-04-02 at 12 31 41 PM
Screenshot 2024-04-02 at 12 29 43 PM
@shindigira shindigira self-assigned this Apr 2, 2024
@shindigira shindigira added bug Something isn't working enhancement New feature or request labels Apr 2, 2024
This was referenced Apr 2, 2024
Closed
Merged
@shindigira shindigira changed the title [FooterCfGov] Too much white space below footer when zoomed out [Design Review] [FooterCfGov] Too much white space below footer when zoomed out Apr 3, 2024
shindigira added a commit that referenced this issue Apr 8, 2024
@shindigira
Design Review - style(App): Fixes having the unnecessary whitespace b…
3d6f145 
…elow the FooterCfGov (#369)

closes #365

## Changes
- style(App): Fixes having the unnecessary whitespace below the
FooterCfGov

## How to test this PR

1. `yarn install` to get the latest DSR update
2. Go to any page where FooterCfGov is used (basically all)
3. Use mobile view and swipe up at the scroll end OR zoom out (CMD + -
multiple times)
4. See how the footer's grey part still extends to the bottom

## Screenshots BEFORE the fix
![Screenshot 2024-04-02 at 12 29 43
PM](https://github.com/cfpb/sbl-frontend/assets/13324863/72228a6a-508d-428c-a1ff-a54f1ef81aeb)
![Screenshot 2024-04-02 at 12 31 41
PM](https://github.com/cfpb/sbl-frontend/assets/13324863/56bc509b-b0d4-4fce-a074-c83f6c810122)

## Screenshot - Fix B (View zoomed out) - Maximizing the footer 
<img width="1552" alt="Screenshot 2024-04-02 at 10 15 16 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/c686516a-978d-451f-b6d3-26930ca808ce">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shindigira shindigira

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@shindigira