-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic] View or update your financial institution profile #11
Comments
Notes from meeting on 8/18/2023Here are the notes that @kristenshaw4 and I took during Friday's meeting with @Kibrael. Please feel free to edit to make these notes more accurate and useful.
Fields to include in R1 designPlease confirm that this list reflects the fields that should be included in the mock-up.
Tagging meeting attendees: @hkeeler @chynnakeys @lchen-2101 @kristenshaw4 @cdorney25 @meissadia @shindigira |
Financial Institution data to show on this page (in this order):
Type of financial institution:A financial institution can select one or more of the following:
Decisions discussed:
Outstanding questions:none User stories
|
Heyo! Everything here looks good @kristenshaw4 and @natalia-fitzgerald, just one little change maybe in the user stories. I think we maybe need to cross out the last user story too after our discussions:
I think we settled on that we usually don't know what information they're missing based on the data we have, so we were going to avoid issuing alerts to the user? |
@billhimmelsbach "Alerted" is probably the wrong word... I think we do want to visualize for them on this page that a field is missing what might be required information for them. Would that be a more accurate statement? |
This is a @Kibrael domain probably, but as I understand it @kristenshaw4, we won't know if most of these fields are required for the institution to include? I think "Parent RSSD ID" is particularly a weird one, since they are required to give it to us if they have one, but some won't since it's something that's assigned to them by the Federal Reserve Board based on their institution type. So it's possible a Parent wouldn't have an RSSD ID, as I understand? Maybe something to chat about during the backlog meeting? It's a little sad to me that we can't do more frontend validation, but what's "required" seems pretty tricky. |
@billhimmelsbach I've done a review of these pages to try to identify any Design System React (DSR) components that are not yet implemented. The only one I've seen so far is Are there any components you've identified as "missing" from the DSR that I can prioritize for development? Anything you've had to implement in your dev branch that needs to be ported over to the DSR? Components I see ( √ = already in DSR) Verified
Draft
|
Thanks @meissadia for doing an inventory of them! How do you want to handle the minor style differences between components in the DSR versus the final designs that are in Figma? Looking at the simplified table for instance:
So for example when I make the SimplifiedTable's top header row without a gray background color for the institution page, should it just be a one-off styling difference from the DSR's default style? Maybe after this issue is completed, we can briefly chat about deciding between maybe rolling some of these similarly minor style changes into the DSR, adding a style prop for major ones, or just leaving them one-off changes? |
@billhimmelsbach There are a mix of components in the DSR. Some are "Verified" and some are "Draft". The table component has not yet been verified. I am adding the components that you will need for this page to the list I will prioritize for the verification review. |
@dan-padgett @angelcardoz |
Next steps
|
DecisionLast week the team discussed the question of conditional logic for the "Update your financial institution profile" form. The team determined that the logic around when or what should be editable (for the identifying and affiliate sections) is too complicated for MVP. For MVP:
Post-MVP:We created a task to capture this work which will be picked up post-MVP: cfpb/sbl-frontend#248 These notes were pulled from the design comments and will inform the post-MVP task:
|
Overview
Resources
Pages
Tasks
User stories
MVP (release date: 12/31/2024)
Open beta (released 8/1/2024)
Backlog
Technical requirements
Content requirements
Financial Institution data to show on this page (in this order):
User testing
Research Goals
Task Ideation
Current designs (MVP)
Updated: 2/16/2024
The text was updated successfully, but these errors were encountered: