diff --git a/core/index.js b/core/index.js index 40fb502a..b9c70a25 100644 --- a/core/index.js +++ b/core/index.js @@ -1,5 +1,5 @@ -global.dde_version = "3.8.3" //require("../package.json").version -global.dde_release_date = "Apr 7, 2022" //require("../package.json").release_date +global.dde_version = "3.8.4" //require("../package.json").version +global.dde_release_date = "May 9, 2022" //require("../package.json").release_date console.log("dde_version: " + global.dde_version + " dde_release_date: " + global.dde_release_date + "\nRead electron_dde/core/job_engine_doc.txt for how to use the Job Engine.\n") diff --git a/core/storage.js b/core/storage.js index f6b2234c..72fbdbb1 100644 --- a/core/storage.js +++ b/core/storage.js @@ -339,13 +339,19 @@ function read_file_async_from_dexter_using_node_server(dex_instance, path, callb // so we add the dde_apps to be consistent with dde's default dir. } let url = "http://" + dex_instance.ip_address + "/edit?edit=" + path //example: "http://192.168.1.142/edit?edit=root/dde_apps/dde_init.js" whereby no beiginning slas actually means going from the server's top level of file system - let content = get_page(url) //does not error if file doens't exist so ... - let the_err = null - if(content.startsWith("Error:")){ - the_err = new Error() - the_err.message = content - content = null + let req = { + uri: url, + encoding: null } + let content_array = get_page(req) //does not error if file doens't exist so ... + let content = content_array.toString("binary"); //Strings can contain binary file content + let the_err = null + + //if(content.startsWith("Error:")){ + // the_err = new Error() + // the_err.message = content + // content = null + //} callback(the_err, content) } @@ -575,8 +581,9 @@ function copy_file_async(source_path, destination_path, callback=null){ } } } - read_file_async(source_path, "ascii", //"binary" should faithfully read and write content without modification. - // "ascii" fails on jpg files. + read_file_async(source_path, null, //"ascii" was used up thru dde3.8.3, but doesn't copy binary files properly + // "binary" *should* faithfully read and write content without modification but doesn't + // "ascii" fails on jpg files. function(err, data){ if(err) { //only call the callback for the read IF there's a read error. diff --git a/doc/guide.html b/doc/guide.html index 5906b93e..4c5dc1fe 100644 --- a/doc/guide.html +++ b/doc/guide.html @@ -8,8 +8,8 @@
About This is Dexter Development Environment
- version: 3.8.3
- released: Apr 7, 2022 + version: 3.8.4
+ released: May 9, 2022

DDE helps you create, debug, and send software to a Dexter robot. You can use any JavaScript augmented with DDE-specific functions to help find out about, diff --git a/doc/release_notes.html b/doc/release_notes.html index 6d4f4ff0..b144a2ca 100644 --- a/doc/release_notes.html +++ b/doc/release_notes.html @@ -5,6 +5,16 @@ } .doc_details summary { font-weight: 600; } + +
v 3.8.4, May 9, 2022 + +
+
v 3.8.3, Apr 7, 2022 Highlights: Bug fixes for Defaults.make_ins file processing.