Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Serial robot doesn't track the port object, can't close port when closing robot #45

Open
JamesNewton opened this issue Jun 11, 2020 · 0 comments

Comments

@JamesNewton
Copy link
Collaborator

The low level serial connect code adds the serial port object into the serial_path_to_info_map entry when it opens a port, and so when the low level close is called, the port can be closed.

The high level serial code does NOT save the port object, but then tries to use it to close the port when the serial robot is closed. This fails, and now no other robot can use that port because it is lost.

(writing this to remind myself to fix it tomorrow am. It's late and I just found this bug, too tired to fix it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant