Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to make value cleanup optional #7

Open
cfchris opened this issue Aug 27, 2020 · 0 comments
Open

Add property to make value cleanup optional #7

cfchris opened this issue Aug 27, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@cfchris
Copy link

cfchris commented Aug 27, 2020

Just getting started on an email compose screen at work. First thing I noticed is that when I open the editor and pass in a user's signature (html), there is a bunch of extra line breaks.

(Signature in TinyMCE in our web app)
signature

(HTML stored in the DB)

<p>Joe Demo<br>

Business Manager<br>

<a href="https://www.example.com">https://www.example.com</a><br>

m: 555-555-1212</p>

(Signature in FlutterSummernote)
signature-in-summernote

Pretty sure this is because of the code that replaces line breaks with <br/> in setText method. (e.g. .replaceAll("\n", "<br/>"))

I would be happy to fork your repo and put up a PR with a new property that makes this optional. Is that something you would be interested in?

@afandiyusuf afandiyusuf added the enhancement New feature or request label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants