Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why ignore chaos_os's response for ActionProcessHang exp creating #1078

Open
spencercjh opened this issue Oct 21, 2024 · 0 comments
Open

Why ignore chaos_os's response for ActionProcessHang exp creating #1078

spencercjh opened this issue Oct 21, 2024 · 0 comments

Comments

@spencercjh
Copy link
Contributor

spencercjh commented Oct 21, 2024

Issue Description

Type: bug report

Describe what happened (or what feature you want)

Why is the result of the experiment creation command ignored when model.ActionProcessHang = true in chaosblade/exec/os/executor.go#Exec? This leads to errors in related experiments (such as CPU, memory, disk load injection, file mutation experiments, etc.) not being returned to the user promptly, which makes the parameter validation before the actual execution of the experiments meaningless.

code:

https://github.com/chaosblade-io/chaosblade/blob/master/exec/os/executor.go#L71-L77

Here is an example:

image

image

The error is hidden in the log, and the outside world only ever gets 200, ok

Describe what you expected to happen

We should not treat model.ActionProcessHang differently. Ignoring the result of the experiment creation command when model.ActionProcessHang is true can lead to issues where errors are not properly reported, affecting the reliability and usability of the experiments.

How to reproduce it (as minimally and precisely as possible)

  1. blade create file append --filepath=/home/logs/not-exist.txt
  2. blade create disk burn --path /not-exist --read --size 10 --timeout 300 --write
  3. ...
@spencercjh spencercjh changed the title Why ignore chaos_os response for ActionProcessHang exp creating Why ignore chaos_os's response for ActionProcessHang exp creating Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant