Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Qthreads patch from #26328 #26440

Open
bradcray opened this issue Dec 19, 2024 · 0 comments
Open

Revert Qthreads patch from #26328 #26440

bradcray opened this issue Dec 19, 2024 · 0 comments

Comments

@bradcray
Copy link
Member

bradcray commented Dec 19, 2024

This task is a placeholder to mark our intention to revert the Qthreads patch added in #26328.

Though that PR seems to have helped with the performance of the test it was designed for ("Array init/deinit performance, 40000000 element array"), it also hurt the performance of several other, arguably more fundamental, tests (link to graphs).

If there was a strong sense that the patch was the most correct and appropriate thing to do, we might keep it and work through the backslides, but talking to @insertinterestingnamehere , it sounds to me more like it was an approach that seemed to be working for the test we were focused on, but not a change with a strong rationale outside of that.

As a result, my current expectation is that we'll revert it in the new year (assuming nobody gets to it today), and I'm filing this issue to remember that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant