Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did you publish this or similar as a package? #1

Open
DullReferenceException opened this issue Apr 21, 2021 · 2 comments
Open

Did you publish this or similar as a package? #1

DullReferenceException opened this issue Apr 21, 2021 · 2 comments

Comments

@DullReferenceException
Copy link

Hello.

I came across the proxyquire issue you opened, and it's the exact problem we face. I have tried out your fork, and it definitely seems to fix the memory leak, but I'm seeing other issues, like with stubs leaking into other proxyquire calls that are not stubbing a built-in module.

You made mention of building a different stubbing solution for your project. Did you open source/publish this? Very interested.

@DullReferenceException
Copy link
Author

DullReferenceException commented Apr 21, 2021

Seems like the only problem I'm having is when stubbing built-in modules like fs and https, so maybe this is something specific to built-in modules.

@charlespwd
Copy link
Owner

This code is what we used for our project. If I recall correctly, we were using this dependency in package.json by referencing the git url to this repo.

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#git-urls-as-dependencies

I have since moved on to different teams and projects and am no longer using it, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants