Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review d3node field in pod #14

Open
jonyrock opened this issue Dec 29, 2020 · 2 comments
Open

review d3node field in pod #14

jonyrock opened this issue Dec 29, 2020 · 2 comments

Comments

@jonyrock
Copy link
Contributor

So Pod has protected readonly d3Node which is the root html element we insert <svg> tag.
I believe that d3Node should wrap <svg> tag, not it's parent.
@jonyrock
Copy link
Contributor Author

The right field now to use is Pod.svg which we remove on each "rendering".
It's all connected with idea to place each pod in a separate <g> element

@jonyrock
Copy link
Contributor Author

This issue will not be actual if we remove d3-related code from the core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonyrock