Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn into native ES module #10

Open
fregante opened this issue Jun 20, 2024 · 2 comments · May be fixed by #11
Open

Turn into native ES module #10

fregante opened this issue Jun 20, 2024 · 2 comments · May be fixed by #11

Comments

@fregante
Copy link

The package is currently being bundled, minified and turned into a CJS module. This seems unnecessary for a node package. It'd be great to drop all that and export a proper ES module

https://www.unpkg.com/browse/@cheap-glitch/[email protected]/index.js
@fregante
Copy link
Author

Also technically the types are wrong because the .ts file (which is used as types only) exports ESM, but the actual .js file is CJS.

@fregante fregante mentioned this issue Jun 20, 2024
Merged
@fregante
Copy link
Author

fregante commented Aug 2, 2024

@cheap-glitch it looks like the package hasn't been published in a while and part of these issue are fixed on main but not on npm

@fregante fregante linked a pull request Aug 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn into ESM fregante/mi-cron
1 participant
@fregante