Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serializer to response wrapper #144

Open
matez0 opened this issue Dec 7, 2023 · 4 comments · May be fixed by #145
Open

Add serializer to response wrapper #144

matez0 opened this issue Dec 7, 2023 · 4 comments · May be fixed by #145
Assignees
@armando-rodriguez-cko
Labels
enhancement New feature or request

Comments

@matez0
Copy link

matez0 commented Dec 7, 2023

Environment

  • Checkout SDK version: latest

Description

A serializer can be useful, when the response fully or partially

  • need to be stored in a database in a JSON serialized form
  • need to be parsed using pydantic or similar parser
  • may be easier to handle that way.

Proposed Solution

  • I may be able to implement this feature.
@matez0 matez0 linked a pull request Dec 7, 2023 that will close this issue
Open
@armando-rodriguez-cko armando-rodriguez-cko self-assigned this Dec 7, 2023
@armando-rodriguez-cko armando-rodriguez-cko added the enhancement New feature or request label Dec 7, 2023
@armando-rodriguez-cko
Copy link
Contributor

Thank you @matez0! We will take a look, but if you want to make a PR we will review it asap.

@matez0
Copy link
Author

matez0 commented Dec 7, 2023

Thank you.
PR: #145

@armando-rodriguez-cko armando-rodriguez-cko linked a pull request Jan 12, 2024 that will close this issue
Add serializer to response wrapper #145
Open
@armando-rodriguez-cko
Copy link
Contributor

We are reviewing it now

@matez0
Copy link
Author

matez0 commented Mar 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armando-rodriguez-cko armando-rodriguez-cko

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add serializer to response wrapper matez0/checkout-sdk-python
2 participants
@matez0 @armando-rodriguez-cko