Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore binaries #1

Open
matryer opened this issue Jan 5, 2015 · 1 comment
Open

Ignore binaries #1

matryer opened this issue Jan 5, 2015 · 1 comment

Comments

@matryer
Copy link
Contributor

matryer commented Jan 5, 2015

It currently searches inside binaries too, madness. Stop it.

@tylerstillwater
Copy link

Detecting if something is a binary executable is difficult, especially in a cross-platform compatible way. I'd recommend having a whitelist of extensions that are searched. This is a tool meant for code and coders, so we can search known code file extensions only.

Alternatively, we could not search a file if it is over a certain size limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants