Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer object hierarchy should be refactored #117

Open
GoogleCodeExporter opened this issue Sep 21, 2015 · 3 comments
Open

Layer object hierarchy should be refactored #117

GoogleCodeExporter opened this issue Sep 21, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

I think it would simplify the object model, more closely align the object model 
with OpenLayers, and greatly reduce redundant code if all Layers descended from 
an AbstractLayer class (on both server and client sides) that provided 
implementation code for common methods and fields.

This is a large undertaking now ... but it is only going to get worse over 
time.  I am willing to help out with the grunt code work, but we do need some 
initial re-design work.

Original issue reported on code.google.com by [email protected] on 30 Nov 2012 at 3:59

@GoogleCodeExporter
Copy link
Author

Maybe a good starting point will be vector and web feature service layer

Original comment by [email protected] on 11 Dec 2012 at 10:05

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

Eiko,

I removed the patch I had attached for this ... it worked fine for the layers 
that extend AbstractComponent, but was problematic for the VectorLayer, which 
extends AbstractComponentContainer.
The problem I'm having here is coming up with a solution that will not involve 
duplicating code because of the different inheritance hierarchies.  Perhaps 
shift all of the other layers over to the AbstractComponentContainer hierarchy? 
 At this point they really aren't containers, but I don't think treating them 
as such would hurt anything.
Do you have some ideas on this?

Thanks,
John Ryan

Original comment by [email protected] on 15 Jan 2013 at 11:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant