Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mf-factor): getInfo is complicate with parametrized dynamic properties #259

Open
tpoisseau opened this issue Dec 19, 2024 · 0 comments
Assignees

Comments

@tpoisseau
Copy link
Collaborator

There is some history behind it and the fact that on one end I wanted to use 'short' properties names (em and mz) and on the other one a property name that means something (monoisotopicMass and observedMonoisotopicMass).

I think it will be time to make some big refactoring and breaking changes and only keep monoisotopicMass and observedMonoisotopicMass but I need to find the time to do it (a lot of implications).

Originally posted by @lpatiny in #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants