From b4f0ca20baf06055a71ac3993f0e9896e6773770 Mon Sep 17 00:00:00 2001 From: Chengjun Hou Date: Fri, 15 Mar 2019 15:58:47 -0400 Subject: [PATCH] submission fix --- .Rbuildignore | 1 + DESCRIPTION | 8 ++++---- cran-comments.md | 6 ++++++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.Rbuildignore b/.Rbuildignore index 537cbfd..4d97374 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -1,3 +1,4 @@ +^CRAN-RELEASE$ ^\.travis\.yml$ ^.*\.Rproj$ ^\.Rproj\.user$ diff --git a/DESCRIPTION b/DESCRIPTION index 5b661da..3d4ed04 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,11 +1,11 @@ Package: xgb2sql Type: Package -Title: Convert Trained XGBoost Model to SQL Query +Title: Convert Trained 'XGBoost' Model to SQL Query Version: 0.1.2 -Description: This tool enables in-database scoring of XGBoost models built in R, by translating trained model objects into SQL query. - XGBoost provides parallel tree boosting (also known as gradient boosting machine, or GBM) algorithms +Description: This tool enables in-database scoring of 'XGBoost' models built in R, by translating trained model objects into SQL query. + 'XGBoost' provides parallel tree boosting (also known as gradient boosting machine, or GBM) algorithms in a highly efficient, flexible and portable way. GBM algorithm is introduced by Friedman (2001) , - and more details on XGBoost can be found in Chen & Guestrin (2016) . + and more details on 'XGBoost' can be found in Chen & Guestrin (2016) . Authors@R: c( person("Chengjun", "Hou", role = c("aut", "cre"), email = "chengjun.hou@gmail.com"), person("Abhishek", "Bishoyi", role = c("aut"), email = "abhishek.bishoyi@gmail.com") diff --git a/cran-comments.md b/cran-comments.md index ab077ad..98c9b89 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,5 +1,11 @@ # New Package Submission - xgb2sql +## Resubmission +This is a resubmission. In this version I have: +* Added single quotes to the word XGBoost as requested by the reviewer. +And according to other packages on CRAN, word SQL stands for the language, same as R. +So single quotes were not added to the word SQL. + ## Resubmission This is a resubmission. In this version I have: * Revised URL of the CRAN page for a task view in canonical form