Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to plasma model properties #294

Open
Mateasek opened this issue May 14, 2021 · 1 comment
Open

Add access to plasma model properties #294

Mateasek opened this issue May 14, 2021 · 1 comment

Comments

@Mateasek
Copy link
Member

Currently PlasmaModel attributes are not accessible from python. Making some of them accessible would provide an easier way of investigating and understanding results provided by cherab. I think in general it would increase the usefulness of the plasma object and sometimes save a lot of time. For example reaction rates could be obtained from the plasma object instead of the need to construct them manually. This could be also useful for debugging of simulations. I propose adding getters to:

ExcitationLine, ExcitationLine:

  • _line
  • _wavelength
  • _rates

TotalRadiatedPower:

  • _element
  • _charge
  • _plt_rate
  • _prb_rate

Are there any more objections to this idea? There can be a reason for the current state which I missed. Also are there any more ideas which could be connected to this change?

@jacklovell
Copy link
Member

I don't see any harm in doing this. You should ensure that the documentation is updated too, to include these properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants