Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precalculate bi/tri-cubic coefficient inverse in cubic interpolators #50

Open
CnlPepper opened this issue Nov 8, 2018 · 1 comment
Open
Assignees

Comments

@CnlPepper
Copy link
Member

The current cubic interpolators are unnecessarily re-inverting the coefficient matrix for each cell. This can be precomputed. This would also improve the numerical accuracy of (beyond 5-6 decimal place) by avoiding an unnecessary pre/post normalisation that occurs around the inversion.

@jacklovell
Copy link
Member

We now recommend the use of Raysect's interpolators, which don't have this issue. All internal uses of the interpolators in Cherab were swapped to Raysect ones in #304. The existing interpolators have been marked as deprecated and retained only for backwards compatibility.

The other place this issue appears is in the caching objects. These are being re-written in #363.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants