Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class functions returning data interpolators to SOLPSSimulation #20

Closed
Mateasek opened this issue Apr 25, 2020 · 1 comment · Fixed by #35
Closed

Add class functions returning data interpolators to SOLPSSimulation #20

Mateasek opened this issue Apr 25, 2020 · 1 comment · Fixed by #35

Comments

@Mateasek
Copy link
Member

I think it would be a nice addition to the SOLPSSimulation. The interpolators are created within the create_plasma function. Moving the code to separate funcions would add a nice possibility to use the solps module for plotting, data generation and etc. together with cherab samplers.

For such purposes functions returning 2D interpolators would be enough, but adding functions returning 3D interpolators shouldn't harm anyone. I would be happy to do this.

vsnever added a commit to vsnever/cherab-solps that referenced this issue Sep 8, 2020
vsnever added a commit to vsnever/cherab-solps that referenced this issue Sep 9, 2020
@vsnever
Copy link
Member

vsnever commented Sep 10, 2020

Just would like to point out that there is one not obvious advantage of SOLPSFunction3D over the AxisymmetricMapper(Discrete2DMesh()) approach. SOLPSFunction3D uses a pointer to the original data on the SOLPS grid, while Discrete2DMesh() copies the data on the triangular mesh on initialisation. So, in case of SOLPSFunction3D, if the original data is manually modified by the user (for example to correct some bad data points), the interpolator does not need to be reinitialised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants