-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look up in cherab.core.atomic.elements instead of using _popular_species and _species_symbol_map dicts #33
Comments
I built these search functions to simplify element handling: You can lookup the element by name, atomic number etc.... |
Yes @CnlPepper, it's exactly what I was looking for, thank you. I'll update the code and make the PR then. @jacklovell, could you please provide me with any |
Current representation of species in |
Fixed in #35. |
I suggest that instead of using _popular_species dict when reading the data from raw or balance files, we should search for the matches in
cherab.core.atomic.elements
. First, get all isotopes with a given nuclear charge, second, from them find the one with the closest atomic mass to the given one.Similarly,
_species_symbol_map
dict must be replaced with the search for the matching element symbol incherab.core.atomic.elements
. Extracting the nuclear charge from the balance file also must be improved the same way.The text was updated successfully, but these errors were encountered: