Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLPS rewrite and tidy-up #8

Closed
CnlPepper opened this issue Sep 18, 2019 · 3 comments · Fixed by #35
Closed

SOLPS rewrite and tidy-up #8

CnlPepper opened this issue Sep 18, 2019 · 3 comments · Fixed by #35

Comments

@CnlPepper
Copy link
Member

There is a lot of bad code in this package that really needs addressing. At present the SOPLS sim object has no way of being initialised without modifying internal, hidden attributes. I've spotted a few cases of API inconsistency and incorrect docstrings.

@mattngc
Copy link
Member

mattngc commented Sep 19, 2019

To be honest, we need a new maintainer for this module. I might post it somewhere. I wrote this module 3+ years ago and have barely worked on it since. Ideally we should find a SOLPS developer or heavy user to look after it.

@vsnever
Copy link
Member

vsnever commented Sep 3, 2020

I think SOLPSSimulation class should be initialised with mesh, species_list instead of just mesh, because this will allow to define property setters that check array dimensions.

@vsnever
Copy link
Member

vsnever commented Sep 3, 2020

Is is safe to remove parallel_velocities and radial_velocities attributes from SOLPSSimulation? Seems like duplicates to velocities_parallel and velocities_radial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants