Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .js extension on three library breaks 3d viewer with black background #6

Open
trailhead opened this issue Oct 26, 2016 · 3 comments

Comments

@trailhead
Copy link

This path appears to be broken...
https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three

This appears to be a valid path, but I can't confirm it fixes the viewer
https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three.js

@chilipeppr
Copy link
Owner

You don't put .js extension when listing files in require.js. Problem is
not with this widget. It is with other ones that reference three that are
not updated to the cdn. Then load order is random.

On Oct 26, 2016 10:08 AM, "Trailhead" [email protected] wrote:

This path appears to be broken...
https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three

This appears to be a valid path, but I can't confirm it fixes the viewer
https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three.js


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AHidbZcETKpsKoN1j38YnXEuw_pPWxBmks5q34kpgaJpZM4KhbZs
.

@trailhead
Copy link
Author

Ok, gotcha. Not an expert at the JS stuff but I can look at the console and poke at a repo. :D

@chilipeppr
Copy link
Owner

Try now. Should be fixed. I updated reference to all widgets that use
Three.js to point to an exact version now:

Three: 'https://cdnjs.cloudflare.com/ajax/libs/three.js/r76/three',

On Wed, Oct 26, 2016 at 10:36 AM, Trailhead [email protected]
wrote:

Ok, gotcha. Not an expert at the JS stuff but I can look at the console
and poke at a repo. :D


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHidbQ1wy0NUohn5gsOZmlCkminofp7Xks5q34-3gaJpZM4KhbZs
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants