Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematize MPro-specific features; remove hardcodes from library #163

Open
dotsdl opened this issue Nov 23, 2021 · 0 comments
Open

Schematize MPro-specific features; remove hardcodes from library #163

dotsdl opened this issue Nov 23, 2021 · 0 comments

Comments

@dotsdl
Copy link
Member

dotsdl commented Nov 23, 2021

The fah-xchem library, and the additions coming in #155 to integrate fah_prep, feature many hardcodes specific to Mpro.

We should attempt to generalize away from these hardcodes. One approach would be to separate the operations each hardcode perform from the objects on which they operate, and place those objects in a schematized form. The schema for Mpro could be defined within the library in its own module for a start, or as part of a test suite. Other targets could be added over time, but don't need to be defined in the library to make use of the operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant