Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace github.com/satori/go.uuid with github.com/gofrs/uuid #470

Closed
ripienaar opened this issue Oct 27, 2018 · 0 comments
Closed

replace github.com/satori/go.uuid with github.com/gofrs/uuid #470

ripienaar opened this issue Oct 27, 2018 · 0 comments
Labels
enhancement

Comments

@ripienaar
Copy link
Member

The satori version has weak random integration and can come up with some weak series of uuid's as per satori/go.uuid#73

Probably not a big deal for this project but nonetheless moving is best as per satori/go.uuid#84
ripienaar added a commit to ripienaar/go-choria that referenced this issue Oct 27, 2018
@ripienaar
(choria-io#470) replace satori/go.uuid with gofrs/uuid
16e3efb 
The satory/go.uuid is abandoned and uses rand in an unsafe way
while the gofrs one is maintained but has an unfortunate API change
to protect against unsafe UUID generation

Rock and a hard place but ultimately making this breaking API change
is the right things to do
ripienaar added a commit to ripienaar/go-choria that referenced this issue Oct 27, 2018
@ripienaar
(choria-io#470) replace satori/go.uuid with gofrs/uuid
ef06a22 
The satory/go.uuid is abandoned and uses rand in an unsafe way
while the gofrs one is maintained but has an unfortunate API change
to protect against unsafe UUID generation

Rock and a hard place but ultimately making this breaking API change
is the right things to do
ripienaar added a commit to ripienaar/go-choria that referenced this issue Oct 27, 2018
@ripienaar
(choria-io#470) replace satori/go.uuid with gofrs/uuid
d4011de 
The satory/go.uuid is abandoned and uses rand in an unsafe way
while the gofrs one is maintained but has an unfortunate API change
to protect against unsafe UUID generation

Rock and a hard place but ultimately making this breaking API change
is the right things to do
ripienaar added a commit to ripienaar/go-choria that referenced this issue Oct 27, 2018
@ripienaar
(choria-io#470) replace satori/go.uuid with gofrs/uuid
442ba6f 
The satory/go.uuid is abandoned and uses rand in an unsafe way
while the gofrs one is maintained but has an unfortunate API change
to protect against unsafe UUID generation

Rock and a hard place but ultimately making this breaking API change
is the right things to do
ripienaar added a commit that referenced this issue Oct 27, 2018
@ripienaar
Merge pull request #471 from ripienaar/470
712b453 
(#470) replace satori/go.uuid with gofrs/uuid
This was referenced Oct 27, 2018
Closed
Closed
@ripienaar ripienaar mentioned this issue Oct 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ripienaar