Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-logging? #2

Open
butlermatt opened this issue Oct 3, 2013 · 0 comments
Open

Meta-logging? #2

butlermatt opened this issue Oct 3, 2013 · 0 comments

Comments

@butlermatt
Copy link

Hi Chris,

I tried dropping an email previously but didn't receive a response. I'm curious on your stance of the meta-logging currently used in the loggerui. In particular the 'adding logrecord' and 'logrecord added'.

At the moment the way it is configured it results in a 2nd event being fired during an event which throws an exception. Uncaught Error: Bad state: Cannot fire new event. Controller is already firing an event

Now as is, I can see two methods of fixing the error. The first is to manually adding the meta-logging to the List, however this will mean that the (console) print functionality work if that's enabled.

The second method is to add the meta logging with a Timer to put it at the end of the event loop. This however will mean that the meta-logging is out of order and loses context.

My personally preference however would be to remove the meta-logging entirely from the library and allow it to be added by the users at their discretion.

Before I submit a pull request for the Polymer fix I wanted to run this situation by you as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant