Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subs Overriding Main RAR File #11

Open
Zemoj opened this issue Jun 2, 2018 · 6 comments
Open

Subs Overriding Main RAR File #11

Zemoj opened this issue Jun 2, 2018 · 6 comments

Comments

@Zemoj
Copy link

Zemoj commented Jun 2, 2018

So there's a weird edge case issue that happens sometimes with files that have sub RARs. Basically the person who created the download puts a RAR with the same name as the movie inside a properly named sub RAR. IE:

/movie/movie.rar
/movie/subs/movie-subs.rar/movie.rar

So when using extract in place, it seems to use the torrent save path, and not each files base path, effectively dropping any sub folders.
Image of code

So it would be great to either respect the sub folders location so it doesn't overwrite the main RAR, or have an option to ignore sub folders altogether.

@fcruz2489
Copy link

I have seen this happening on my end as well, was digging around and tinkering with the settings for a while until i finally found this post that explained the issue. Would be awesome if we could get this fixed. Thanks so much!

Zemoj added a commit to Zemoj/deluge-extractor that referenced this issue Jul 18, 2018
Fix for issue chrishuan9#11 without adding new features.
@indecline
Copy link

I also have this problem, would love to have it fixed!

@indecline
Copy link

Thanks guys, is there a bug here or am I not compiling it correctly?

image

@Zemoj
Copy link
Author

Zemoj commented Jan 21, 2019

Probably a bug on my part. Try this:
if os.stat(dest)[stat.ST_SIZE] > 0

@indecline
Copy link

Probably a bug on my part. Try this:
if os.stat(dest)[stat.ST_SIZE] > 0

That failed as well but just looking at it again and the colon was missing off the end. The below appears to work

if os.stat(dest)[stat.ST_SIZE] > 0:

@indecline
Copy link

Hmmm don't think this is working correctly, can't get it to extract anything. Have you tried it with the updated code @Zemoj ?

chrishuan9 pushed a commit that referenced this issue May 22, 2022
Add .r00 file extension for unrar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants