New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass static typing tests #249

Open

1 of 6 tasks

chrislit opened this issue Jan 21, 2020 · 1 comment

Labels

refactoring testing

Milestone

Owner

chrislit commented Jan 21, 2020 •

edited

Loading

Add static type hinting & test with mypy. This issue will get moved from release to release until each task is complete (which might never occur).

Tasks:

complete mypy abydos with no errors
remove calls to cast (they're not free...)
add type hints to every function/method (enable disallow_incomplete_defs = True & disallow_untyped_defs = True in [mypy] of setup.cfg)
clean out Union types (consider making simpler non-Unions)
eliminate # type: ignore
transition variable type hints to Py3.7+ style (after removing Py3.6 support)

The text was updated successfully, but these errors were encountered:

chrislit added testing refactoring labels

chrislit added this to the 0.6 milestone

chrislit modified the milestones: 0.6, 0.7

Owner Author

chrislit commented Jan 5, 2022

I may do a bit of this before releasing 0.6, but 3.6-support probably will stay until 0.6's release, so the final task can't be done yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment