Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS build error on GitHub pages #157

Open
martin-nc opened this issue May 15, 2024 · 4 comments
Open

SASS build error on GitHub pages #157

martin-nc opened this issue May 15, 2024 · 4 comments

Comments

@martin-nc
Copy link

Hi, we're suddenly getting a build error on our site:
Rendering Markup: assets/css/app.scss github-pages 231 | Error: Invalid CSS after "... arrow($color: ": expected expression (e.g. 1px, bold), was "#{cv.getVar("li..." on line 4 Remote Theme: Cleaning up /tmp/jekyll-remote-theme-20240515-8-x5t49m
Is this down to any recent changes? We haven't touched the SASS for a while. The code is here: https://github.com/elixir-europe/biohackathon-europe-2024.

Thanks!

@chrisrhymes
Copy link
Owner

Hi @martin-nc,

Please can you try setting your remote theme to v0.14.0 as per the readme and see if this resolves your error?

@chrisrhymes chrisrhymes pinned this issue May 15, 2024
@martin-nc
Copy link
Author

Hi @chrisrhymes great- that's fixed it! Sorry - I missed that update.

Incidentally, I added a couple of things to the theme in our instance:

  1. A "skip to content" link for accessibility. You can see this appearing at the top of the screen if you navigate the page using only the tab key: https://biohackathon-europe.org/.
  2. A sticky footer. Maybe this is more of a judgement call, but if you have a short page then it means the footer doesn't hang half-way down it on a large screen e.g. https://biohackathon-europe.org/programme/.
    I can create a PR for either of these if you're interested. The code might need tidying and abstracting so it works reasonably well in different contexts. Or perhaps you'd like to keep things simpler and leave it to the developer to implement stuff like that.

Thanks anyway!

@martin-nc
Copy link
Author

Ah - now my override styles have gone, but I'll fix that.

@chrisrhymes
Copy link
Owner

Hello @martin-nc , sorry for the delayed response. The skip to content link sounds very useful if you have time to implement that in a pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants