-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: Sleep or kill phrase #54
Comments
+1 here, sometimes my bot goes on a schizophrenic rampage and it would be great to have a |
Thanks for the suggestion! In terms of automatic stopping, you can use either For I've been thinking of a |
My intended use is something along the lines of: (Bot is typing a huge 500 token response filled with nothing meaningful) |
Adding to that, a few lines down there is also a |
I think it would be better as a set able word like the wake words just in reverse. |
@chrisrude I've very roughly implemented my own /stop command into bot_commands.py and ooba_client.py (with my limited knowledge) and I'm wondering how far into it you are. I can make a PR now, but my current implementation is simply a hardcoded URL to my oobabooga server, so it wouldn't work out of the box.
|
Feel free to have a stab at it if you like! I was rushing to get other features out so haven't started on this yet. Or if you want you could also just send over a work in progress PR and then I can polish off things you're unsure about. Thanks for your help! |
I sure gave it a stab! |
Still interested in this feature, and it's one of the priorities to be implemented sooner rather than later. My time has been split between a few projects recently, though, so it may still be a few weeks before I'm able to get it more packaged. @jmoney7823956789378 if you're comfortable with a larger change, the main work that needs to be done from the PR above is:
In particular, I'm curious about testing the case where there are multiple replies in the queue and /stop is invoked. I would hope it would simply cancel the in-progress request without affecting the others, but it's also possible that something would break there. You'd be totally welcome to step in more if you're interested, if not I'll work on getting to it in the next few updates. Those may be somewhat delayed to to commitments I have on other projects. Thanks again for all your help so far! |
In all honesty I'm totally clueless about how the settings are pulled from config.yml, and I also have some important stuff coming up that might keep me off the project for a few weeks.
So far I believe it stops only the current message in queue, so maybe it should be renamed to /cancel :) |
No worries! I appreciate having non-github priorities as well. :) Thanks again for all your help so far, and don't worry I'll get this in at some point. :) |
So... did you get to this, is now /timeout a reality or still not? People in my server are complaining it's talking too much and responding to everyone once it starts, timeout command is necessary to make it stop talking unless addressed (tagged) again. |
You might be better off disabling unsolicited replies. |
Some kind of set phrase like the wake phrases that stop the bot. I don't know for sure if the stopping_strings is that setting or if there is something i'm missing.
The text was updated successfully, but these errors were encountered: