New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index + Subindex missing from abort messages #377

Open

mbs38 opened this issue May 12, 2023 · 1 comment

Labels

bug help wanted

mbs38 commented May 12, 2023

Hi, thanks for the great work.

I noticed that index + subindex are missing from the client side abort messages when comparing the raw data to a commercial tool I'm using. Index + subindex have to be included according to the standard. See https://forum.opencyphal.org/uploads/short-url/mNWuvY23DYckSFoSbfam0ji3YWn.pdf Page 61.

Code:
https://github.com/christiansandberg/canopen/blob/e8807b87e69902840f459279ce38e330b069f53d/canopen/sdo/client.py#LL92C1-L100C1

Thx!

friederschueler added enhancement help wanted bug and removed enhancement labels

Collaborator

friederschueler commented Jun 13, 2024

I think this is a bug, because we are not following the standard.

Could you provide the different raw data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment