Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for supported CIs #77

Open
christophebedard opened this issue Jun 25, 2020 · 0 comments
Open

Add more tests for supported CIs #77

christophebedard opened this issue Jun 25, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@christophebedard
Copy link
Owner

Follow-up to #2

Currently, the supported CIs are tested by actually running dco-check (via a test) in PRs. That only tests a portion of the features: it doesn't test pushing to the default branch.

This would be a bit more complex to test, since we would need to emulate the CI environments (i.e. define the right env var, provide the right data, etc.), create some commits, and run dco-check.

A first step could be to do this with a simple git repo that we set up in a test.

@christophebedard christophebedard added the enhancement New feature or request label Jun 25, 2020
@christophebedard christophebedard self-assigned this Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant