From 57fcbcdf49510296c8f9d206cab8a5694b6e0e8b Mon Sep 17 00:00:00 2001
From: Hammad Bashir <HammadB@users.noreply.github.com>
Date: Tue, 30 Apr 2024 22:19:02 -0700
Subject: [PATCH] [ENH] Pass env into helm for query/compaction services
 (#2094)

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 -Pass env into helm for query/compaction services
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
---
 k8s/distributed-chroma/templates/compaction-service.yaml | 2 ++
 k8s/distributed-chroma/templates/query-service.yaml      | 2 ++
 k8s/distributed-chroma/values.yaml                       | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/k8s/distributed-chroma/templates/compaction-service.yaml b/k8s/distributed-chroma/templates/compaction-service.yaml
index b3df32956f5..57c829dcd5a 100644
--- a/k8s/distributed-chroma/templates/compaction-service.yaml
+++ b/k8s/distributed-chroma/templates/compaction-service.yaml
@@ -22,10 +22,12 @@ spec:
           ports:
             - containerPort: 50051
           env:
+            {{ range .Values.compactionService.env }}
             - name: CHROMA_COMPACTION_SERVICE__MY_IP
               valueFrom:
                 fieldRef:
                   fieldPath: status.podIP
+            {{ end }}
       topologySpreadConstraints:
         - maxSkew: 1
           topologyKey: "kubernetes.io/hostname"
diff --git a/k8s/distributed-chroma/templates/query-service.yaml b/k8s/distributed-chroma/templates/query-service.yaml
index fba80e65bc7..c4dc3ac7f73 100644
--- a/k8s/distributed-chroma/templates/query-service.yaml
+++ b/k8s/distributed-chroma/templates/query-service.yaml
@@ -43,10 +43,12 @@ spec:
             - name: chroma
               mountPath: /index_data
           env:
+            {{ range .Values.queryService.env }}
             - name: CHROMA_QUERY_SERVICE__MY_IP
               valueFrom:
                 fieldRef:
                   fieldPath: status.podIP
+            {{ end }}
       topologySpreadConstraints:
         - maxSkew: 1
           topologyKey: "kubernetes.io/hostname"
diff --git a/k8s/distributed-chroma/values.yaml b/k8s/distributed-chroma/values.yaml
index 0ef185b9f7f..b7e05d122b6 100644
--- a/k8s/distributed-chroma/values.yaml
+++ b/k8s/distributed-chroma/values.yaml
@@ -51,11 +51,13 @@ queryService:
   image:
     repository: 'local'
     tag: 'query-service'
+  env:
 
 compactionService:
   image:
     repository: 'local'
     tag: 'compaction-service'
+  env:
 
 sysdbMigration:
   image: