Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide instructions for using Subspace in a CMake-based project #226

Closed
danakj opened this issue Mar 18, 2023 · 5 comments
Closed

Provide instructions for using Subspace in a CMake-based project #226

danakj opened this issue Mar 18, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@danakj
Copy link
Collaborator

danakj commented Mar 18, 2023

We have some instructions for checking out and building Subspace, but no integration instructions.

Presumably this is easy for CMake pros, but some steps would be good, that include disabling CIR/Subdoc. And that include enabling the clang-tidy! Once it's merged.

Possibly we should consider vcpkg or something?

@dj2 From your past submissions it seems like you were optimizing this path, do you have any opinions or help you could lend?
@danakj danakj added the enhancement New feature or request label Mar 18, 2023
@dj2
Copy link
Contributor

dj2 commented Mar 19, 2023

I'll try to write down some steps for the case where you submodule in subspace. For the world of using FindPackage or vcpkg that's outside the realm of what I usually do.

@danakj
Copy link
Collaborator Author

danakj commented Mar 19, 2023

Cool :) Very appreciated!

@dj2
Copy link
Contributor

dj2 commented Mar 27, 2023

This might take a bit longer then expected. Github wouldn't let me update my fork, so I deleted it, and now it won't let me fork the subspace repo. I just get an oops message. Will try again in a few days to see if they've fixed whatever is going on ....

@danakj
Copy link
Collaborator Author

danakj commented Mar 27, 2023

Weird 😕

@danakj
Copy link
Collaborator Author

danakj commented May 1, 2023

Is Github still giving problems?

dj2 added a commit to dj2/subspace that referenced this issue May 2, 2023
@dj2
Add cmake notes; make tests optional.
6905cfd 
This CL adds some documentation on integrating subspace with CMake. In
order to make the integration simpler the test files have been moved
inside a `SUBSPACE_BUILD_TESTS` cmake option. This allows disabling the
subspace tests when integrating.

Issue chromium#226
@dj2 dj2 mentioned this issue May 2, 2023
Merged
danakj pushed a commit that referenced this issue May 9, 2023
@dj2 @danakj
Add cmake notes; make tests optional.
9bcd786 
This CL adds some documentation on integrating subspace with CMake. In
order to make the integration simpler the test files have been moved
inside a `SUBSPACE_BUILD_TESTS` cmake option. This allows disabling the
subspace tests when integrating.

Issue #226
@danakj danakj closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dj2 @danakj