Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdoc Bugs exposed by libjxl #370

Open
2 tasks
danakj opened this issue Sep 13, 2023 · 7 comments
Open
2 tasks

Subdoc Bugs exposed by libjxl #370

danakj opened this issue Sep 13, 2023 · 7 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@danakj
Copy link
Collaborator

danakj commented Sep 13, 2023

JxlColorProfile

https://old.lucaversari.it/jpeg_xl_data/docs/JxlColorProfile.html

  • Here there's a data member icc whose type is ::(unnamed struct at /fast-data/libjxl/lib/include/jxl/cms_interface.h:47:3)
  • The struct fields links don't know the path to the struct's page, and are linking to .html
@danakj danakj added the documentation Improvements or additions to documentation label Sep 13, 2023
@veluca93
Copy link
Contributor

/**
 * Opaque structure that holds the JPEG XL decoder.
 *
 * Allocated and initialized with @ref JxlDecoderCreate().
 * Cleaned up and deallocated with @ref JxlDecoderDestroy().
 */
typedef struct JxlDecoderStruct JxlDecoder;                               

@danakj
Copy link
Collaborator Author

danakj commented Sep 13, 2023

typedefs are completely ignored atm, that one is in the TODOs. (except what we fixed today for typedef struct {} S;

@veluca93
Copy link
Contributor

Running it on the full code, it seems that subdoc doesn't find a bunch of the hwy functions and namespaces.

@danakj
Copy link
Collaborator Author

danakj commented Sep 14, 2023

Could you give a link to an example function?

@veluca93
Copy link
Contributor

Could you give a link to an example function?

https://github.com/libjxl/libjxl/blob/97e5ab0916af36ff4ea8c47a21a551281ee79949/lib/jxl/inverse_mtf-inl.h#L53

this one is found, but only in namespaces N_SSE4 and N_SSE2, while the compile flags should cause it to appear also in i.e. namespace N_AVX2.

@danakj
Copy link
Collaborator Author

danakj commented Sep 14, 2023

One possible cause is it skips decls that it has visited based on location. However subspace uses .inc files 5 times out of one header, and each one is visited separately.

@danakj danakj added this to the Subdoc milestone Sep 17, 2023
@danakj
Copy link
Collaborator Author

danakj commented Dec 10, 2023

type aliases and macros now generate. macros only generate if the prefix matches a prefix from --include-macro-prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants