Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix DisplayTest.AutoResize failures #3156

Open
magreenblatt opened this issue Jul 1, 2021 · 3 comments
Open

tests: Fix DisplayTest.AutoResize failures #3156

magreenblatt opened this issue Jul 1, 2021 · 3 comments
Labels
bug Bug report Tests Related to tests

Comments

@magreenblatt
Copy link
Collaborator

Original report by wujh (Bitbucket: wujh, GitHub: wujh).

1,What steps will reproduce the problem?

The rect values are different from expectations when I testing DisplayTest.AutoResize and OSRTest.Popup*

the fail show:

DisplayTest.AutoResize

Note: Google Test filter = DisplayTest.AutoResize
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from DisplayTest
[ RUN      ] DisplayTest.AutoResize
tests/ceftests/display_unittest.cc:183: Failure
Expected equality of these values:
  50
  new_size.width
    Which is: 54
tests/ceftests/display_unittest.cc:184: Failure
Expected equality of these values:
  18
  new_size.height
    Which is: 21
tests/ceftests/display_unittest.cc:192: Failure
Expected equality of these values:
  50
  new_size.width
    Which is: 54
tests/ceftests/display_unittest.cc:193: Failure
Expected equality of these values:
  36
  new_size.height
    Which is: 42
[  FAILED  ] DisplayTest.AutoResize (347 ms)
[----------] 1 test from DisplayTest (347 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (347 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DisplayTest.AutoResize

 1 FAILED TEST

‌

OSRTest.Popup*

‌

Note: Google Test filter = DisplayTest.AutoResize
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from DisplayTest
[ RUN      ] DisplayTest.AutoResize
tests/ceftests/display_unittest.cc:183: Failure
Expected equality of these values:
  50
  new_size.width
    Which is: 54
tests/ceftests/display_unittest.cc:184: Failure
Expected equality of these values:
  18
  new_size.height
    Which is: 21
tests/ceftests/display_unittest.cc:192: Failure
Expected equality of these values:
  50
  new_size.width
    Which is: 54
tests/ceftests/display_unittest.cc:193: Failure
Expected equality of these values:
  36
  new_size.height
    Which is: 42
[  FAILED  ] DisplayTest.AutoResize (347 ms)
[----------] 1 test from DisplayTest (347 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (347 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DisplayTest.AutoResize

 1 FAILED TEST
loongson@loongson-pc:~$ cat osrtest.popup.txt 
Note: Google Test filter = OSRTest.Popup*
[==========] Running 16 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 16 tests from OSRTest
[ RUN      ] OSRTest.PopupPaint
tests/ceftests/os_rendering_unittest.cc:511: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
tests/ceftests/os_rendering_unittest.cc:787: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  dirtyRects[0].height
    Which is: 354
tests/ceftests/os_rendering_unittest.cc:802: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
[  FAILED  ] OSRTest.PopupPaint (381 ms)
[ RUN      ] OSRTest.PopupPaint2x
[       OK ] OSRTest.PopupPaint2x (262 ms)
[ RUN      ] OSRTest.PopupShow
[       OK ] OSRTest.PopupShow (142 ms)
[ RUN      ] OSRTest.PopupShow2x
[       OK ] OSRTest.PopupShow2x (208 ms)
[ RUN      ] OSRTest.PopupSize
tests/ceftests/os_rendering_unittest.cc:480: Failure
Expected equality of these values:
  kExpandedSelectRect.x
    Which is: 462
  rect.x
    Which is: 469
tests/ceftests/os_rendering_unittest.cc:481: Failure
Expected equality of these values:
  kExpandedSelectRect.y
    Which is: 42
  rect.y
    Which is: 46
tests/ceftests/os_rendering_unittest.cc:484: Failure
Expected equality of these values:
  kExpandedSelectRect.height
    Which is: 334
  rect.height
    Which is: 354
[  FAILED  ] OSRTest.PopupSize (148 ms)
[ RUN      ] OSRTest.PopupSize2x
tests/ceftests/os_rendering_unittest.cc:480: Failure
Expected equality of these values:
  kExpandedSelectRect.x
    Which is: 462
  rect.x
    Which is: 469
tests/ceftests/os_rendering_unittest.cc:481: Failure
Expected equality of these values:
  kExpandedSelectRect.y
    Which is: 42
  rect.y
    Which is: 46
[  FAILED  ] OSRTest.PopupSize2x (208 ms)
[ RUN      ] OSRTest.PopupHideOnBlur
tests/ceftests/os_rendering_unittest.cc:511: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
[  FAILED  ] OSRTest.PopupHideOnBlur (181 ms)
[ RUN      ] OSRTest.PopupHideOnBlur2x
[       OK ] OSRTest.PopupHideOnBlur2x (228 ms)
[ RUN      ] OSRTest.PopupHideOnClick
tests/ceftests/os_rendering_unittest.cc:511: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
[  FAILED  ] OSRTest.PopupHideOnClick (175 ms)
[ RUN      ] OSRTest.PopupHideOnClick2x
[       OK ] OSRTest.PopupHideOnClick2x (245 ms)
[ RUN      ] OSRTest.PopupHideOnScroll
tests/ceftests/os_rendering_unittest.cc:511: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
[  FAILED  ] OSRTest.PopupHideOnScroll (180 ms)
[ RUN      ] OSRTest.PopupHideOnScroll2x
[       OK ] OSRTest.PopupHideOnScroll2x (246 ms)
[ RUN      ] OSRTest.PopupHideOnEsc
tests/ceftests/os_rendering_unittest.cc:511: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
[  FAILED  ] OSRTest.PopupHideOnEsc (197 ms)
[ RUN      ] OSRTest.PopupHideOnEsc2x
[       OK ] OSRTest.PopupHideOnEsc2x (224 ms)
[ RUN      ] OSRTest.PopupScrollInside
tests/ceftests/os_rendering_unittest.cc:511: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
tests/ceftests/os_rendering_unittest.cc:511: Failure
Expected equality of these values:
  expanded_select_rect.height
    Which is: 334
  height
    Which is: 354
tests/ceftests/os_rendering_unittest.cc:839: Failure
The difference between expanded_select_rect.height and dirtyRects[0].height is 18, which exceeds scaled_int_1 * 2, where
expanded_select_rect.height evaluates to 334,
dirtyRects[0].height evaluates to 352, and
scaled_int_1 * 2 evaluates to 2.
[  FAILED  ] OSRTest.PopupScrollInside (175 ms)
[ RUN      ] OSRTest.PopupScrollInside2x
[       OK ] OSRTest.PopupScrollInside2x (241 ms)
[----------] 16 tests from OSRTest (3443 ms total)

[----------] Global test environment tear-down
[==========] 16 tests from 1 test suite ran. (3443 ms total)
[  PASSED  ] 8 tests.
[  FAILED  ] 8 tests, listed below:
[  FAILED  ] OSRTest.PopupPaint
[  FAILED  ] OSRTest.PopupSize
[  FAILED  ] OSRTest.PopupSize2x
[  FAILED  ] OSRTest.PopupHideOnBlur
[  FAILED  ] OSRTest.PopupHideOnClick
[  FAILED  ] OSRTest.PopupHideOnScroll
[  FAILED  ] OSRTest.PopupHideOnEsc
[  FAILED  ] OSRTest.PopupScrollInside

 8 FAILED TESTS

2,What is the expected output? What do you see instead?

These values are the same as expected

3,What version of the product are you using? On what operating system?

cef_binary_90.6.5+g7a604aa+chromium-90.0.4430.93_linux

‌
@magreenblatt
Copy link
Collaborator Author

A PR to fix these failures would be welcome.

@magreenblatt
Copy link
Collaborator Author

  • changed title from "some values are differrent from expectations in DisplayTest.AutoResize and OSRTest.Popup* test items" to "Linux: DisplayTest.AutoResize and OSRTest.Popup* test failures"
  • changed component from "Unclassified" to "Tests"

@magreenblatt magreenblatt added the osr Related to off-screen rendering label Mar 12, 2023
@magreenblatt magreenblatt added the help wanted Issue resolution will likely require community contributions label Jul 8, 2024
@magreenblatt
Copy link
Collaborator Author

magreenblatt commented Nov 18, 2024 •
edited
Loading

OSRTest.Popup* failures will be handled in #3832.

@magreenblatt magreenblatt changed the title Linux: DisplayTest.AutoResize and OSRTest.Popup* test failures tests: DisplayTest.AutoResize failures Nov 18, 2024
@magreenblatt magreenblatt removed help wanted Issue resolution will likely require community contributions linux Linux platform osr Related to off-screen rendering labels Nov 18, 2024
@magreenblatt magreenblatt changed the title tests: DisplayTest.AutoResize failures tests: Fix DisplayTest.AutoResize failures Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug report Tests Related to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magreenblatt