Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cefclient aborted popup keeps application from terminating #3776

Open
rocknowradio opened this issue Aug 28, 2024 · 4 comments
Open

cefclient aborted popup keeps application from terminating #3776

rocknowradio opened this issue Aug 28, 2024 · 4 comments
Labels
bug Bug report cefclient Related to the cefclient sample app windows Windows platform

Comments

@rocknowradio
Copy link
Contributor

Describe the bug
If FileDialogHandler::OnFileDialog gets invoked, cefclient does not terminate.

To Reproduce
Steps to reproduce the behavior:

  1. Download Sample Application (127.3.5+g114ea2a 127.0.6533.120) Windows x64.
  2. Open cefclient using cefclient --url=http://egghunter.in/safepay/file.html --enable-chrome-runtime (--disable-chrome-runtime yields the same result).
  3. Click on the Click Here... image. This will invoke a file open dialog (in the background will attempt to also open a new popup, but even without this the result is the same).
  4. Close the file dialog (either dismiss or pick a file).
  5. Close cefclient.

Expected behavior
cefclient should close normally.

Screenshots
Not needed

Versions (please complete the following information):

  • OS: Windows 10 x64
  • CEF Version: 127.3.5

Additional context
Does the problem reproduce with the cefclient or cefsimple sample application at the same version?
cefclient: Yes
cefsimple: No

Does the problem reproduce with Google Chrome at the same version?
No

@magreenblatt
Copy link
Collaborator

Reproduces for me with M130 on Windows 11. The window closes but processes are still running in Task Manager.

@magreenblatt
Copy link
Collaborator

This does not appear to reproduce with the file open dialogs from https://tests/dialogs

@magreenblatt
Copy link
Collaborator

magreenblatt commented Sep 30, 2024

in the background will attempt to also open a new popup

Looks like cefclient's popup handling is the issue. The problem is avoided by running with --use-default-popup

It would be useful to test if calling preventDefault() and/or preventImmediatePropagation() in the onclick handler (to avoid the popup) also avoids the problem.

@magreenblatt magreenblatt added the cefclient Related to the cefclient sample app label Sep 30, 2024
@magreenblatt magreenblatt changed the title cefclient does not close if file open dialog invoked cefclient aborted popup keeps application from terminating Sep 30, 2024
@rocknowradio
Copy link
Contributor Author

I will debug all of these. I plan to upgrade to CEF 129 and this is on the regression list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report cefclient Related to the cefclient sample app windows Windows platform
Projects
None yet
Development

No branches or pull requests

2 participants