Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure 'stan' #64

Closed
3 tasks
chshersh opened this issue Aug 8, 2022 · 3 comments · Fixed by #79
Closed
3 tasks

Configure 'stan' #64

chshersh opened this issue Aug 8, 2022 · 3 comments · Fixed by #79
Labels
⚗️ dx Dev experience improvements

Comments

@chshersh
Copy link
Owner

chshersh commented Aug 8, 2022

Stan is a Haskell static analyser. To get the most of Haskell DX, it would be nice to configure it as well.

  • Add Stan config
  • Add Stan CI job
  • Fix or ignore all Stan warnings
@chshersh chshersh added the ⚗️ dx Dev experience improvements label Aug 8, 2022
@chshersh chshersh moved this to Todo in Iris Project Aug 8, 2022
@german1608
Copy link
Contributor

Hi there!

I'd like to work on this!

I built both projects (iris and stan) using GHC 8.10.7, and got the following output, using no stan config at all:

Screen Shot 2022-10-02 at 4 27 34 PM

And we already have the config starting at GHC 8.8 (I'm unfamiliar if HIE are supported since this version).

iris/iris.cabal

Lines 42 to 45 in 1bede5f

if impl(ghc >= 8.8)
ghc-options: -Wmissing-deriving-strategies
-fwrite-ide-info
-hiedir=.hie

I've read about stan a while ago, but this is the first time I actually use it. We can start with an empty .stan.toml file, and add config as the project grow, or you may suggest a starting point for the config. I'm happy regardless.

@chshersh
Copy link
Owner Author

chshersh commented Oct 3, 2022

Thanks for giving it a go!

I agree that we can start with an empty .stan.toml config and add things later if needeed 🙂

The error you see is in the autogenerated by Cabal modules so we can't fix them. We can only ignore them. And this is what needs to be put in the config 🙂

However, looks like this is impossible at the moment due to the following Stan issue:

@german1608
Copy link
Contributor

Oh, I see, I didn't noted the file was autogenerated.

alright then, I'll take a look at this soon.

Thanks for your kind response.

chshersh pushed a commit that referenced this issue Oct 8, 2022
Resolves #64

* ci: add stan configuration
* Delete .stan.toml since it's empty
* Use `stan-` prefix for the cabal cache
* Include GHC version on the stan workflow name
* Rename ghc version from stan job name
Repository owner moved this from Todo to Done in Iris Project Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚗️ dx Dev experience improvements
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants