Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdeaVim: eb doesn't select the current word #3

Open
sdoerner opened this issue Nov 28, 2024 · 6 comments · May be fixed by #4
Open

IdeaVim: eb doesn't select the current word #3

sdoerner opened this issue Nov 28, 2024 · 6 comments · May be fixed by #4
Labels

Comments

@sdoerner
Copy link

In Helix, you can use eb to select the current word. This doesn't seem to work in helix.idea.vim (didn't test other editor configs). Instead, it selects the first character of the word, and the character before that.

@chtenb
Copy link
Owner

chtenb commented Nov 28, 2024

Yes, see my comment in the Idea PR: #2 (comment)
The vanilla motions I wrote in helix.vim don't appear to work in IdeaVim.
I cannot test this because I do not use IdeaVim IDEs, and the author of the PR did not figure out how to implement the word motions.
If you want to take a stab at properly implementing these motions for IdeaVim, that would be great.

@sdoerner
Copy link
Author

It seems like ]` (jump to next lowercase mark) does not work in IdeaVim, same with "previous lowercase mark".

I tried just replacing it with `a but that doesn't work. The feature seems to be needed to handle some edge cases wrt. whitespace.

For now, I filed a bug with IdeaVim to add support for this motion: https://youtrack.jetbrains.com/issue/VIM-3731/Add-support-for-jump-to-previous-next-lowercase-mark

@ristomatti
Copy link
Contributor

Great to see other IDEA users here as well! I quite literally took a jump in the deep end with this since I've never been an advanced Vim user (even though I used it ~10 years as the default shell editor).

@ristomatti
Copy link
Contributor

@sdoerner Perhaps update the issue title to e.g "IdeaVim: eb doesn't select the current word" as IdeaVim support was contributed by me and does not match 1:1 to the great work done by @chtenb for Vim itself.

@sdoerner sdoerner changed the title eb doesn't select the current word IdeaVim: eb doesn't select the current word Dec 3, 2024
@chtenb chtenb added the IdeaVim label Dec 3, 2024
sdoerner added a commit to sdoerner/helix.vim that referenced this issue Dec 15, 2024
These lead to issues and are not needed after merging the upstream
JetBrains/ideavim#1068.

Fixes: chtenb#3
@sdoerner
Copy link
Author

I fixed the upstream bug and sent them a PR. After that, we need to remove some visual mode overrides (#4).

PR #4 is in draft mode so far, as the upstream PR isn't merged or released yet.

If anyone is up for building IdeaVim from source, please let me know how this works for you.

@ristomatti
Copy link
Contributor

If anyone is up for building IdeaVim from source, please let me know how this works for you.

I'd love to but sadly I'm too busy with other stuff for the coming months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants