Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenreader users can't type text #67

Open
brandynbennett opened this issue Nov 1, 2017 · 1 comment
Open

Screenreader users can't type text #67

brandynbennett opened this issue Nov 1, 2017 · 1 comment

Comments

@brandynbennett
Copy link
Contributor

Because the ember-basic-dropdown trigger element has an aria-role of button a screenreader is unable to enter the typeahead area to do any typing.

I think it would make sense to make a triggerRole property in ember-power-select that would be passed through to the role attribute on the ember-basic-dropdown trigger.

The <input> on the ember-power-select-typeahead/trigger should also have a role of combobox

power-select-typeahead-a11y-issue
@brandynbennett brandynbennett changed the title Screenreaders can't type text Screenreaders users can't type text Nov 1, 2017
@brandynbennett brandynbennett changed the title Screenreaders users can't type text Screenreader users can't type text Nov 1, 2017
brandynbennett added a commit to brandynbennett/ember-power-select that referenced this issue Nov 1, 2017
@brandynbennett
Allow triggerRole to be set
2aa0c1f 
Part of fix for cibernox/ember-power-select-typeahead#67
in `ember-power-select-typeahead`
brandynbennett added a commit to brandynbennett/ember-power-select that referenced this issue Nov 1, 2017
@brandynbennett
Allow triggerRole to be set
ae71e4d 
Part of fix for cibernox/ember-power-select-typeahead#67
in `ember-power-select-typeahead`
@brandynbennett brandynbennett mentioned this issue Nov 1, 2017
Merged
brandynbennett added a commit to brandynbennett/ember-power-select-typeahead that referenced this issue Nov 1, 2017
@brandynbennett
Fix Screenreader issue from cibernox#67
d5dddec 
A new version of `ember-power-select` accepts a `triggerRole`
attribute which makes it possible to remove the `role="button"`
that was on the trigger element, preventing screenreaders from
typing
brandynbennett added a commit to brandynbennett/ember-power-select-typeahead that referenced this issue Nov 1, 2017
@brandynbennett
Fix Screenreader issue from cibernox#67
426d93a 
A new version of `ember-power-select` accepts a `triggerRole`
attribute which makes it possible to remove the `role="button"`
that was on the trigger element, preventing screenreaders from
typing
brandynbennett added a commit to brandynbennett/ember-power-select that referenced this issue Nov 6, 2017
@brandynbennett
Allow triggerRole to be set
e5c7b0e 
Part of fix for cibernox/ember-power-select-typeahead#67
in `ember-power-select-typeahead`
brandynbennett added a commit to brandynbennett/ember-power-select that referenced this issue Nov 6, 2017
@brandynbennett
Allow triggerRole to be set
03707bf 
Part of fix for cibernox/ember-power-select-typeahead#67
in `ember-power-select-typeahead`
brandynbennett added a commit to brandynbennett/ember-power-select that referenced this issue Nov 6, 2017
@brandynbennett
Allow triggerRole to be set
df8cc62 
Part of fix for cibernox/ember-power-select-typeahead#67
in `ember-power-select-typeahead`
cibernox pushed a commit to cibernox/ember-power-select that referenced this issue Nov 7, 2017
@brandynbennett @cibernox
Allow triggerRole to be set (#1009)
db48a58 
Part of fix for cibernox/ember-power-select-typeahead#67
in `ember-power-select-typeahead`
brandynbennett added a commit to brandynbennett/ember-power-select-typeahead that referenced this issue Nov 7, 2017
@brandynbennett
Fix Screenreader issue from cibernox#67
b7d6de5 
A new version of `ember-power-select` accepts a `triggerRole`
attribute which makes it possible to remove the `role="button"`
that was on the trigger element, preventing screenreaders from
typing
brandynbennett added a commit to brandynbennett/ember-power-select-typeahead that referenced this issue Nov 7, 2017
@brandynbennett
Fix Screenreader issue from cibernox#67
9239e41 
A new version of `ember-power-select` accepts a `triggerRole`
attribute which makes it possible to remove the `role="button"`
that was on the trigger element, preventing screenreaders from
typing
cibernox added a commit that referenced this issue Nov 7, 2017
@cibernox
Merge pull request #68 from brandynbennett/master
1c0a99d 
Fix Screenreader issue from #67
@acorncom
Copy link

acorncom commented Apr 3, 2018

Looks like this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acorncom @brandynbennett