Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-constant observables #578

Closed
sabinala opened this issue May 15, 2024 · 4 comments · Fixed by #580
Closed

Allow non-constant observables #578

sabinala opened this issue May 15, 2024 · 4 comments · Fixed by #580
Labels
enhancement New feature or request

Comments

@sabinala
Copy link
Contributor

sabinala commented May 15, 2024

Currently, parameters in observable expressions must be constant, but we should allow non-constant (or sampled) parameter values.

@sabinala sabinala added the enhancement New feature or request label May 15, 2024
@SamWitty
Copy link
Contributor

SamWitty commented Jun 5, 2024

@sabinala , I believe observables can already support parameters values in their definitions. Do you have an example where this behavior does not work as expected?

@sabinala
Copy link
Contributor Author

sabinala commented Jun 5, 2024

@SamWitty
Copy link
Contributor

SamWitty commented Jun 5, 2024

Great, thank you. Could you please create an AMR at https://raw.githubusercontent.com/DARPA-ASKEM/simulation-integration/main/data/models/ so that I can add a test when I address this issue. I'll plan on taking this on now.

@SamWitty SamWitty linked a pull request Jun 5, 2024 that will close this issue
@sabinala
Copy link
Contributor Author

sabinala commented Jun 5, 2024

@SamWitty Here's the PR to add that AMR: DARPA-ASKEM/simulation-integration#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants