diff --git a/contrib/upgrade-notes/latest.md b/contrib/upgrade-notes/latest.md index 21fabe08d8d..9402e12c29e 100644 --- a/contrib/upgrade-notes/latest.md +++ b/contrib/upgrade-notes/latest.md @@ -62,3 +62,4 @@ tetragon: * `tetragon_event_cache_retries_total` metric is renamed to `tetragon_event_cache_fetch_retries_total`. * `tetragon_errors_total{type="event_missing_process_info"}` metric is replaced by `tetragon_events_missing_process_info_total`. +* `tetragon_errors_total{type="handler_error"}` metric is removed. Use `tetragon_handler_errors_total` instead. diff --git a/docs/content/en/docs/reference/metrics.md b/docs/content/en/docs/reference/metrics.md index 1297aa9cb2f..27d20ee2c84 100644 --- a/docs/content/en/docs/reference/metrics.md +++ b/docs/content/en/docs/reference/metrics.md @@ -51,7 +51,7 @@ The total number of Tetragon errors. For internal use only. | label | values | | ----- | ------ | -| `type ` | `event_finalize_process_info_failed, handler_error, process_metadata_username_failed, process_metadata_username_ignored_not_in_host_namespaces, process_pid_tid_mismatch` | +| `type ` | `event_finalize_process_info_failed, process_metadata_username_failed, process_metadata_username_ignored_not_in_host_namespaces, process_pid_tid_mismatch` | ### `tetragon_event_cache_entries` diff --git a/pkg/metrics/errormetrics/errormetrics.go b/pkg/metrics/errormetrics/errormetrics.go index ee7a722321f..fcb7d6fe900 100644 --- a/pkg/metrics/errormetrics/errormetrics.go +++ b/pkg/metrics/errormetrics/errormetrics.go @@ -17,8 +17,6 @@ type ErrorType int const ( // Tid and Pid mismatch that could affect BPF and user space caching logic ProcessPidTidMismatch ErrorType = iota - // An error occurred in an event handler. - HandlerError // An event finalizer on Process failed EventFinalizeProcessInfoFailed // Failed to resolve Process uid to username @@ -30,7 +28,6 @@ const ( var errorTypeLabelValues = map[ErrorType]string{ ProcessPidTidMismatch: "process_pid_tid_mismatch", - HandlerError: "handler_error", EventFinalizeProcessInfoFailed: "event_finalize_process_info_failed", ProcessMetadataUsernameFailed: "process_metadata_username_failed", ProcessMetadataUsernameIgnoredNotInHost: "process_metadata_username_ignored_not_in_host_namespaces", diff --git a/pkg/observer/observer.go b/pkg/observer/observer.go index 91adb828cf5..1cb21b13b67 100644 --- a/pkg/observer/observer.go +++ b/pkg/observer/observer.go @@ -124,8 +124,6 @@ func (k *Observer) receiveEvent(data []byte) { op, events, err := HandlePerfData(data) opcodemetrics.OpTotalInc(ops.OpCode(op)) if err != nil { - // Increment error metrics - errormetrics.ErrorTotalInc(errormetrics.HandlerError) errormetrics.HandlerErrorsInc(ops.OpCode(op), err.kind) switch err.kind { case errormetrics.HandlePerfUnknownOp: