Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: add linters on error checks and return #989

Closed
mtardy opened this issue May 11, 2023 · 1 comment
Closed

cleanup: add linters on error checks and return #989

mtardy opened this issue May 11, 2023 · 1 comment
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mtardy
Copy link
Member

mtardy commented May 11, 2023

After the following cleanup:

It would be nice to enable these linters about errors, but it will be some amount of work since they return a lots of alerts.

  • errcheck (this one is particularly important)
  • nilerr
  • errorlint
  • nilnil

We could see if we can then catch situations where we use the return value before checking the error as well.

@mtardy mtardy added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 11, 2023
@mtardy mtardy self-assigned this May 11, 2023
@jrfastab
Copy link
Contributor

this is old and happy with linters now. closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants