Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual product report.json files are not covered by smoke test #1193

Closed
mitchelbaker-cisa opened this issue Jul 1, 2024 · 3 comments
Closed
Labels
enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function

Comments

@mitchelbaker-cisa
Copy link
Collaborator

🐛 Summary

#970 added support for a ScubaResults.json which houses metadata, a json version of the html reports, and more. The PR adds test coverage for the MergeJson parameter across:

However, if MergeJson is not specified, individual product report.json (AADReport.json, DefenderReport.json, etc.) files are created by default.

Screenshot (119)

These are not included in SmokeTest001.Tests.ps1:

Screenshot (118)

To reproduce

Run Invoke-SCuBA without -MergeJson parameter from main branch/v1.3.0

Expected behavior

  1. When reviewing Create Json Output #970 Crutch mentioned not needing the individual json reports (comment). If these files are not necessary, then the tool should not create them and coverage is not needed in the smoke test.
  2. If we deem these files necessary, then we should update the smoke test.
@schrolla
Copy link
Collaborator

schrolla commented Jul 8, 2024

@adhilto Please add reference to MergeJson flag removal/change issue to this for discussion.

@schrolla schrolla added this to the Backlog milestone Jul 8, 2024
@schrolla schrolla added enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function labels Jul 8, 2024
@adhilto
Copy link
Collaborator

adhilto commented Jul 8, 2024

Note that the individual json files would go away completely if/when we make MergeJson the default behavior (#1205), dependent on #1023. If we do make that change, then I think this issue would be OBE.

@buidav
Copy link
Collaborator

buidav commented Sep 17, 2024

Superseded by #1317

@buidav buidav closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
@schrolla schrolla removed this from the Backlog milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function
Projects
None yet
Development

No branches or pull requests

4 participants