Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharePoint incorrectly produces N/A for policy 3.3 #1307

Open
mitchelbaker-cisa opened this issue Sep 6, 2024 · 0 comments
Open

SharePoint incorrectly produces N/A for policy 3.3 #1307

mitchelbaker-cisa opened this issue Sep 6, 2024 · 0 comments
Assignees
Milestone

Comments

@mitchelbaker-cisa
Copy link
Collaborator

🐛 Summary

MS.SHAREPOINT.3.3v1 states the following which is incorrect:

  • Note: This policy is only applicable if the external sharing slider on the admin center sharing page is set to Anyone or New and existing guests.

To reproduce

Steps to reproduce the behavior:

  1. Sign in to SharePoint admin center, go to Policies > Sharing
  2. Change the external sharing slider to "Existing Guests", "New and existing guests", and "Anyone" and note the checkbox for People who use a verification code must reauthenticate after this many days is displayed in all three options.

Expected behavior

  1. MS.SHAREPOINT.3.3v1 should be revised to be:
  • Note: This policy is only applicable if the external sharing slider on the admin center sharing page is not set to Only people in your organization.

Rego changes need to be made to reflect above:

# Standard case
tests contain { ... } if {
  SharingCapability in [NEWANDEXISTINGGUESTS, ANYONE, EXISTINGGUESTS]
}

# N/A case
tests contain { ... } if {
  SharingCapability != ONLYPEOPLEINORG
}

Screenshot (202)

Any helpful log output or screenshots

Current policy:

Screenshot (197)

@mitchelbaker-cisa mitchelbaker-cisa self-assigned this Sep 6, 2024
@schrolla schrolla added this to the Kraken milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants