Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange unit tests result in warnings due to long lines #1322

Open
schrolla opened this issue Sep 19, 2024 · 0 comments
Open

Exchange unit tests result in warnings due to long lines #1322

schrolla opened this issue Sep 19, 2024 · 0 comments
Labels
bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function
Milestone

Comments

@schrolla
Copy link
Collaborator

🐛 Summary

The refactored Exchange Rego unit tests contain lines beyond the style limit resulting in warnings from Regal when running linting in workflows. These warnings are shown as annotations/notes on workflow results from the OPA Unit Tests workflow.

To reproduce

Steps to reproduce the behavior:

  1. Run the OPA Unit tests workflow on a recent branch or main
  2. Then review the results and look for warnings

Expected behavior

For the unit tests to run and not produce any warnings.

Any helpful log output or screenshots

See this action result as an example of the offending warnings.
https://github.com/cisagov/ScubaGear/actions/runs/10908058113

Also, here is a screenshot showing the offending warnings.
Screenshot 2024-09-19 at 11 57 03 AM

@schrolla schrolla added bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function labels Sep 19, 2024
@schrolla schrolla added this to the Kraken milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function
Projects
None yet
Development

No branches or pull requests

1 participant